[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 05/10] Fix bug in setting up child stderr/out with /dev/null



On Wed, Nov 17, 2010 at 09:28:57PM -0700, Eric Blake wrote:
> From: Daniel P. Berrange <berrange redhat com>
> 
> ---
>  src/util/util.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/util/util.c b/src/util/util.c
> index 2d6485f..f2fe58a 100644
> --- a/src/util/util.c
> +++ b/src/util/util.c
> @@ -463,7 +463,7 @@ __virExec(const char *const*argv,
>      int childerr = -1;
>      int tmpfd;
> 
> -    if ((null = open("/dev/null", O_RDONLY)) < 0) {
> +    if ((null = open("/dev/null", O_RDWR)) < 0) {
>          virReportSystemError(errno,
>                               _("cannot open %s"),
>                               "/dev/null");

ACK

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]