[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/11] Fix parsing of port attribute in storage XML configuration



On 11/12/2010 11:36 AM, Daniel P. Berrange wrote:
> On Fri, Nov 12, 2010 at 10:21:16AM -0700, Eric Blake wrote:
>> On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
>>> The XML docs describe a 'port' attribute for the
>>> storage source <host> element, but the parser never
>>> handled it.
>>>
>>> * docs/schemas/storagepool.rng: Define port attribute
>>> * src/conf/storage_conf.c: Add missing parsing/formatting
>>>   of host port number
>>> * src/conf/storage_conf.h: Remove bogus/unused 'protocol' field
>>> ---
>>>  docs/schemas/storagepool.rng |    5 +++++
>>
>> Missing corresponding docs/formatstorage.html.in change.
> 
> As per the commit message, this is already documented, but not
> implemented !

Good to know.

> 
>>> diff --git a/docs/schemas/storagepool.rng b/docs/schemas/storagepool.rng
>>> index 54eb802..8f067f3 100644
>>> --- a/docs/schemas/storagepool.rng
>>> +++ b/docs/schemas/storagepool.rng
>>> @@ -186,6 +186,11 @@
>>>        <attribute name='name'>
>>>          <text/>
>>>        </attribute>
>>> +      <optional>
>>> +        <attribute name='port'>
>>> +          <text/>
>>
>> Is text really appropriate?
> 
> I guess it should reference a port number
> 

I don't see this patch applied yet.  ACK with that nit to the schema fixed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]