[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/11] Add support for iSCSI target auto-discovery



On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
> Since the previous patch added support for parsing the output of
> the 'sendtargets' command, it is now trivial to support the
> storage pool discovery API.
> 
> Given a hostname and optional portnumber and initiator IQN,
> the code can return a full list of storage pool source docs,
> each one representing a iSCSI target.
> 
> * src/storage/storage_backend_iscsi.c: Wire up target
>   auto-discovery
> ---
>  
> +static char *
> +virStorageBackendISCSIFindPoolSources(virConnectPtr conn ATTRIBUTE_UNUSED,
> +                                      const char *srcSpec,
> +                                      unsigned int flags ATTRIBUTE_UNUSED)
> +{

Should this check that flags==0?

ACK with that nit addressed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]