[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/10] Remove bogus includes



On 11/18/2010 02:51 AM, Daniel P. Berrange wrote:
> On Wed, Nov 17, 2010 at 09:28:59PM -0700, Eric Blake wrote:
>> From: Daniel P. Berrange <berrange redhat com>
>>
>> ---
>>  src/conf/domain_conf.c |    1 -
>>  src/util/hooks.c       |    1 -
>>  2 files changed, 0 insertions(+), 2 deletions(-)
>>
> 
> You might want to re-check this one - when I re-tested with macvtap
> enabled, it caused a build failure.

What failure did you see?  From my config.log:

configure:42373: =====================
configure:42375:
configure:42377: Drivers
configure:42379:
configure:42381:      Xen: yes
configure:42383:     QEMU: yes
configure:42385:      UML: yes
configure:42387:   OpenVZ: yes
configure:42389:     VBox: yes
configure:42391:   XenAPI: yes
configure:42393:      LXC: yes
configure:42395:     PHYP: yes
configure:42397:      ONE: yes
configure:42399:      ESX: yes
configure:42401:     Test: yes
configure:42403:   Remote: yes
configure:42405:  Network: yes
configure:42407: Libvirtd: yes
configure:42409:    netcf: yes
configure:42411:  macvtap: yes
configure:42413: virtport: yes

so I'm compiling with macvtap, and not seeing any failures.  The
original patch from you that I amended had one more file touched for a
removed include, but that removal did cause compilation failures.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]