[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] storage_file: Add a new flag to mark backing files that are safe to probe



On Mon, 2010-11-22 at 11:04 +0000, Daniel P. Berrange wrote: 
> > diff --git a/src/util/storage_file.h b/src/util/storage_file.h
> > index c4d4650..13c731f 100644
> > --- a/src/util/storage_file.h
> > +++ b/src/util/storage_file.h
> > @@ -30,6 +30,7 @@
> >  enum virStorageFileFormat {
> >      VIR_STORAGE_FILE_AUTO = -1,
> >      VIR_STORAGE_FILE_RAW = 0,
> > +    VIR_STORAGE_FILE_AUTO_SAFE,
> 
> You need to make sure that this is set to '-2', otherwise
> this value becomes parsable in the XML which is not
> desired. THis avoids the need to add it to the enum
> above.

Ah, of course.  I'll respin the series to incorporate this, and some of
the other items Eric suggested.


> >      VIR_STORAGE_FILE_DIR,
> >      VIR_STORAGE_FILE_BOCHS,
> >      VIR_STORAGE_FILE_CLOOP,
> 
> 
> Daniel

-- 
Thanks,
Adam


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]