[libvirt] [PATCH] Rename 'remove' param to 'toremove' to avoid clash with Win32 header

Eric Blake eblake at redhat.com
Tue Nov 23 15:11:56 UTC 2010


On 11/23/2010 06:33 AM, Daniel P. Berrange wrote:
> The win32 headers have a function called 'remove' declared. This
> clashes with the 'remove' parameter in virShrinkN

Not just win32, but all <stdio.h> implementations.

> 
> * src/util/memory.c: Rename 'remove' to 'toremove'
> ---
>  src/util/memory.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)

ACK.  Wonder why -Wshadow didn't catch that for me?

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20101123/902fba92/attachment-0001.sig>


More information about the libvir-list mailing list