[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] Add unit tests for internal CPU APIs



> > *** BLURB HERE ***
> 
> Ignoring git's hint to add an overview, are we? :)

Not really ignoring, just not noticing and forgetting :-)

> > Jiri Denemark (2):
> >   cpu: Add support for overriding path to CPU map XML file
> >   tests: Add unit tests for internal CPU APIs
> 
> ACK series, but should tests/cputest.c be given a copyright notice?
Ah sure, I will add it.

> Also, make sure 'make syntax-check' passes; I noticed a failure on
> sc_prohibit_empty_lines_at_EOF on tests/sputestdata/x86-nehalem-force.xml.
And I would have sworn I did syntax-check... apparently I didn't. I'll fix
that too.

Just wondering if this is an after-release thing or not. But I guess I can
just wait few days before pushing and be safe.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]