[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] 1/1: implement usb and pci hot attach in AppArmor driver



On 10/01/2010 07:07 AM, Eric Blake wrote:
<snip>
Maybe it's me, but stylistically, I like ?: for these uses:
ctl->append = arg == 'F';

They make it a real PITA to follow when debugging (ie in Eclipse)
though.

When the if has the value assignment on separate lines, there's no
doubt at all about which way the decision went.  Using ?, the person
doing the debugging either has to do extra debugging work (adding
further mental distraction), or make an assumption (potential gotcha).

I kind of hate the ? short hand in code I have to debug, due to this.

;>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]