[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/12] vcpu: add current attribute to <vcpu> element



On Wed, Sep 29, 2010 at 06:02:06PM -0600, Eric Blake wrote:
> Syntax agreed on in
> https://www.redhat.com/archives/libvir-list/2010-September/msg00476.html
> 
> * docs/schemas/domain.rng: Add new attribute.
> * docs/formatdomain.html.in: Document it.
> * tests/qemuxml2argvdata/qemuxml2argv-smp.xml: Add to
> domainschematest.
> * tests/xml2sexprdata/xml2sexpr-pv-vcpus.xml: Likewise.
> ---
>  docs/formatdomain.html.in                   |    9 +++++--
>  docs/schemas/domain.rng                     |    5 ++++
>  tests/qemuxml2argvdata/qemuxml2argv-smp.xml |   28 +++++++++++++++++++++++++++
>  tests/xml2sexprdata/xml2sexpr-pv-vcpus.xml  |   22 +++++++++++++++++++++
>  4 files changed, 61 insertions(+), 3 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smp.xml
>  create mode 100644 tests/xml2sexprdata/xml2sexpr-pv-vcpus.xml

> @@ -220,7 +220,10 @@
>          list of physical CPU numbers that virtual CPUs can be pinned
>          to.  Each element in that list is either a single CPU number,
>          a range of CPU numbers, or a caret followed by a CPU number to
> -        be excluded from a previous range.
> +        be excluded from a previous range.  <span class="since">Since
> +        0.8.5</span>, the optional attribute <code>current</code> can
> +        be used to specify that fewer than the maximum number of

  "that fewer" doesn't sounds so nice, "when fewer" would work
or "that less", but it's a nitpick and I'm not even an english native
speaker so my opinion is not worth much :-)

> +        virtual CPUs should be enabled.
>        </dd>
>      </dl>

ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]