[libvirt] OSX 10.6 build failures

[Justin Clift]

On 10/01/2010 03:26 AM, Eric Blake wrote:
> On 09/14/2010 05:42 PM, Justin Clift wrote:
>> b) pkg-config
>>
>> The next thing to barf was autoconf, complaining about AC_MSG_ERROR
>> not being a defined macro.
>>
>> Googling with some persistence showed this is caused by pkg-config
>> not being installed. Fixed that.
>>
>> Will submit a patch for that too. Probably "pkg-config --version"
>> based, copying the approach used for the other autogen.sh checks.
>
> Revisiting this, does it suffice to add pkg-config into the $buildreq
> table of bootstrap.conf?

That seems to be an improvement.  Without pkg-config installed, running
autogen.sh gives this failure:

****************************************
$ ./autogen.sh
<snip>
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... build-aux/install-sh -c -d
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
configure: error: cannot run /bin/sh build-aux/config.sub
$
****************************************

With it added, we get:

****************************************
$ ./autogen.sh
running bootstrap...
Error: 'CONFIG-pkg-config' not found

Program    Min_version
----------------------
autoconf   2.59
automake   1.9.6
autopoint  -
gettext    -
git        1.5.5
gzip       -
libtool    -
perl       5.5
pkg-config -
tar        -
----------------------
Failed to bootstrap gnulib, please investigate.
$
****************************************

As a "clarity of error message" idea, do you reckon it's workable
for the error message to list the status of each item?

Something like:

****************************************
$ ./autogen.sh
running bootstrap...
Error: 'CONFIG-pkg-config' not found

Program    Min_version    Status
-----------------------------------------
autoconf   2.59           OK - 2.61 found
automake   1.9.6          OK - 1.10 found
autopoint  -              OK
gettext    -              OK
git        1.5.5          OK - 1.73 found
gzip       -              OK
libtool    -              OK
perl       5.5            OK - 5.10 found
pkg-config -              MISSING
tar        -              OK
-----------------------------------------
Failed to bootstrap gnulib, please investigate.
$
****************************************

It just seems like it would convey the problem (and implied solution) in 
a clearer fashion.

As a thought, after installing pkg-config back onto the system, the
above error about "CONFIG-pkg-config" not being found still happens,
so something isn't right. :/

Any ideas?