[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Added new attribute exportfs_type to filesystem element



On Thu, Sep 30, 2010 at 10:30:10PM +0530, Harsh Prateek Bora wrote:
> This patch introduces a new attribute export_fs to the filesystem
> element which specifies the type of export. Currently only 'local'
> type of exported filesystem is supported. More types like NFS, clusterFS, etc.
> can be added later as required.
> 
> Note: This patch is based on the following two patches:
> 1) Daniel's patch to support 9pfs:
> https://www.redhat.com/archives/libvir-list/2010-September/msg00358.html
> 2) Another related patch to support 'security_model' attribute:
> https://www.redhat.com/archives/libvir-list/2010-September/msg00435.html
> 
> Signed-off-by: Harsh Prateek Bora <harsh linux vnet ibm com>

  Okay, I don't understand what's the point of adding that attribute
with only one possible value and systematically generated.
  I think it's better to propose this when there is an actual use
case for the attribute, then it will be easier to say if this is the
right construct to add or not.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]