[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 01/13] Adding structure and defines for virDomainSet/GetMemoryParameters



On Tue, Sep 28, 2010 at 03:26:15PM +0530, Nikunj A. Dadhania wrote:
> +
> +/* Set memory tunables for the domain*/
> +int     virDomainSetMemoryParameters(virDomainPtr domain,
> +				     virMemoryParameterPtr params,
> +				     int nparams);
> +/* Get memory tunables for the domain, caller allocates the params if nparams
> + * is zero and params is NULL, the domain returns back number of parameters
> + * supported by the HV. This could be used by the caller to allocate the
> + * memory and call with params structure allocated.
> + */
> +int     virDomainGetMemoryParameters(virDomainPtr domain,
> +				     virMemoryParameterPtr params,
> +				     int *nparams);

We should add an  'unsigned int flags' parameter to both of these,
so we can extend their semantics in the future. The comment here
can be moved to the libvirt.c file so it gets picked up in the API
docs.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]