[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix several minor problems introduced by the memtune series



On Tue, Oct 12, 2010 at 09:29:38PM +0200, Matthias Bolte wrote:
> Add proper documentation to the new VIR_DOMAIN_MEMORY_* macros in
> libvirt.h.in to placate apibuild.py.
> 
> Mark args as unused in for libvirt_virDomain{Get,Set}MemoryParameters
> in the Python bindings and add both to the libvirtMethods array.
> 
> Update remote_protocol-structs to placate make syntax-check.
> 
> Undo unintended modifications in vboxDomainGetInfo.
> 
> Update the function table of the VirtualBox and XenAPI drivers.

  Gahh, thanks for catching those !

> diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs
> index a5fc6aa..838423e 100644
> --- a/src/remote_protocol-structs
> +++ b/src/remote_protocol-structs
> @@ -70,6 +70,21 @@ struct remote_sched_param {
>  	remote_nonnull_string      field;
>  	remote_sched_param_value   value;
>  };
> +struct remote_memory_param_value {
> +	int                        type;
> +	union {
> +		int                i;
> +		u_int              ui;
> +		int64_t            l;
> +		uint64_t           ul;
> +		double             d;
> +		int                b;
> +	} remote_memory_param_value_u;
> +};
> +struct remote_memory_param {
> +	remote_nonnull_string      field;
> +	remote_memory_param_value  value;
> +};
>  struct remote_open_args {
>  	remote_string              name;
>  	int                        flags;
> @@ -151,6 +166,26 @@ struct remote_domain_set_scheduler_parameters_args {
>  		remote_sched_param * params_val;
>  	} params;
>  };
> +struct remote_domain_set_memory_parameters_args {
> +	remote_nonnull_domain      dom;
> +	struct {
> +		u_int              params_len;
> +		remote_memory_param * params_val;
> +	} params;
> +	u_int                      flags;
> +};
> +struct remote_domain_get_memory_parameters_args {
> +	remote_nonnull_domain      dom;
> +	int                        nparams;
> +	u_int                      flags;
> +};
> +struct remote_domain_get_memory_parameters_ret {
> +	struct {
> +		u_int              params_len;
> +		remote_memory_param * params_val;
> +	} params;
> +	int                        nparams;
> +};
>  struct remote_domain_block_stats_args {
>  	remote_nonnull_domain      dom;
>  	remote_nonnull_string      path;

  Hum, that file I didn't know about ... aren't those already
declared in the .x so why the duplication, I'm surprized !

Daniel


-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]