[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: simplify top-level option parsing



On Tue, Oct 12, 2010 at 03:51:48PM -0600, Eric Blake wrote:
> This makes 'virsh --conn test:///default help help' work right;
> previously, the abbreviation confused our hand-rolled option parsing.
> 
> * tools/virsh.c (vshParseArgv): Use getopt_long feature, rather
> than (incorrectly) reparsing options ourselves.
> ---
> 
> > Oh my - I just looked in the code, and virsh is re-doing option
> > parsing by itself, instead of just telling getopt_long() to stop on
> > the first non-option; but getting it wrong by not checking for
> > abbreviations. Another patch or two coming up...
> 
> I love patches that nuke more code than they add, all while fixing
> bugs at the same time!
> 
>  tools/virsh.c |   68 +++++++++++++-------------------------------------------
>  1 files changed, 16 insertions(+), 52 deletions(-)

  ACK, way cleaner !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]