[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Conditionally include termios.h



On 10/13/2010 06:16 AM, Eric Blake wrote:
On 10/13/2010 04:34 AM, Daniel P. Berrange wrote:
The configure.ac file checks for termios.h, but its use is
not protected by HAVE_TERMIOS_H. This breaks the build on
mingw32

* src/util/util.c: Conditionally include termios.h

NACK. Gnulib provides the termios header replacement, we just need to
fix bootstrap.conf to use the gnulib module.

And looking further, bootstrap.conf already includes 'termios'. What exactly was your failure? Besides, making things conditional should have caused a 'make syntax-check' failure, since we now try to enforce that all gnulib replacement headers be used unconditionally. Is there a bug in that syntax check rule?

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]