[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: update comment about parsing



On Tue, Oct 12, 2010 at 04:26:01PM -0600, Eric Blake wrote:
> * tools/virsh.c: Update comments to match patch series.
> ---
> 
> Noticed this one in reviewing the file once again; it's doc only, so
> I'll apply it without an ACK once the rest of the series is in place.
> 
>  tools/virsh.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/virsh.c b/tools/virsh.c
> index 4929f71..89c2e1e 100644
> --- a/tools/virsh.c
> +++ b/tools/virsh.c
> @@ -100,18 +100,18 @@ typedef enum {
>   *
>   *    command_line    =     <command>\n | <command>; <command>; ...
>   *
> - *    command         =    <keyword> <option> <data>
> + *    command         =    <keyword> <option> [--] <data>
>   *
>   *    option          =     <bool_option> | <int_option> | <string_option>
>   *    data            =     <string>
>   *
>   *    bool_option     =     --optionname
> - *    int_option      =     --optionname <number>
> - *    string_option   =     --optionname <string>
> + *    int_option      =     --optionname <number> | --optionname=<number>
> + *    string_option   =     --optionname <string> | --optionname=<string>
>   *
> - *    keyword         =     [a-zA-Z]
> + *    keyword         =     [a-zA-Z][a-zA-Z-]*
>   *    number          =     [0-9]+
> - *    string          =     [^[:blank:]] | "[[:alnum:]]"$
> + *    string          =     ('[^']*'|"([^\\"]|\\.)*"|([^ \t\n\\'"]|\\.))+
>   *
>   */

  The last regexps makes the head spin a bit but if used to it that's
  logical :-)

ACK

Also ACK to the initial 8 patch series, so basically the whole set
including your extra patches are fine for me, please commit, it will
be easier for you :-)

  thanks to Lai and you !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]