[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Conditionally include termios.h



On Wed, Oct 13, 2010 at 06:16:03AM -0600, Eric Blake wrote:
> On 10/13/2010 04:34 AM, Daniel P. Berrange wrote:
> >The configure.ac file checks for termios.h, but its use is
> >not protected by HAVE_TERMIOS_H. This breaks the build on
> >mingw32
> >
> >* src/util/util.c: Conditionally include termios.h
> 
> NACK.  Gnulib provides the termios header replacement, we just need to 
> fix bootstrap.conf to use the gnulib module.

On mingw32 the gnulib replacement does not seem to work though, hence
configure is undefining HAVE_TERMIOS_H in config.h.

The gnulib replacement is doing an include_next <termios.h> but there
is no next one to include.

If the gnulib can be relied upon to always provide the header, then
surely we don't need the termios.h header check in configure.ac ?

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]