[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] introduce VIR_CLOSE to be used rather than close()



[adding bug-gnulib]

On 10/15/2010 03:58 PM, Stefan Berger wrote:

+# include<stdbool.h>
+
+# include "internal.h"

You need #include "ignore-value.h"...

The problem with this include file is that it doesn't protect itself from
multiple inclusion with a #ifndef, #define sequence, so I ended up getting
re-definitions of ignore_value. So I pushed the #include into the .c
files.

Oh, I missed that. It's always easier, maintenance wise, for every header to be idempotent, so let's fix this in gnulib.


Well, let me know whether you agree and I'll push with the nits addressed.

Hmm; maybe it's easier to wait for the gnulib update to go in first.

Many changes .. I'll post a V3.

Good idea.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]