[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Handle Windows-1252 encoded VMX files



2010/10/16 Matthias Bolte <matthias bolte googlemail com>:
> ESX(i) uses UTF-8, but a Windows based GSX server writes
> Windows-1252 encoded VMX files.
> ---
>  src/esx/esx_util.c   |   48 +++++++++++++++++++++++++++++++++++++++++++++---
>  src/esx/esx_util.h   |    2 ++
>  src/esx/esx_vmx.c    |   33 +++++++++++++++++++++++++++++++++
>  tests/esxutilstest.c |   41 +++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 121 insertions(+), 3 deletions(-)
>

I hit the send button to early... Why limit this to Windows-1252
encoding when it could accept all encodings that libxml2 (using
libiconv/glibc) can convert to UTF-8. Therefore, this patch is
replaced with a more general one:

  https://www.redhat.com/archives/libvir-list/2010-October/msg00517.html

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]