[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Handle non-UTF-8 encoded VMX files



On 10/16/2010 12:37 PM, Matthias Bolte wrote:
ESX(i) uses UTF-8, but a Windows based GSX server writes
Windows-1252 encoded VMX files.

Add a test case to ensure that libxml2 provides Windows-1252
to UTF-8 conversion.
---


+
+    if (result == NULL) {
+        virReportOOMError();
+        goto cleanup;
+    }
+
+  cleanup:

Is that last goto necessary, since the label is reached next anyways?

ACK with that nit addressed.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]