[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Handle non-UTF-8 encoded VMX files



On 10/18/2010 10:22 AM, Laine Stump wrote:
+
+ if (result == NULL) {
+ virReportOOMError();
+ goto cleanup;
+ }
+
+ cleanup:

Is that last goto necessary, since the label is reached next anyways?

Maybe this is a defensive goto, assuming that someday someone may add
extra code after that if clause. And for the moment it's just a single
jmp that gets optimized out. (kind of like putting a break on the last
case of a switch statement. It doesn't do anything now, but may save
your bacon later if Ralph Wiggum goes playing in your code ;-))

Fair enough :) Although one would hope that our review process exists to shield us somewhat from whatever Ralph Wiggum's coding style throws at us :)

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]