[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Handle non-UTF-8 encoded VMX files

On Mon, Oct 18, 2010 at 10:37:31AM -0600, Eric Blake wrote:
> On 10/18/2010 10:22 AM, Laine Stump wrote:
> >>>+
> >>>+ if (result == NULL) {
> >>>+ virReportOOMError();
> >>>+ goto cleanup;
> >>>+ }
> >>>+
> >>>+ cleanup:
> >>
> >>Is that last goto necessary, since the label is reached next anyways?
> >
> >Maybe this is a defensive goto, assuming that someday someone may add
> >extra code after that if clause. And for the moment it's just a single
> >jmp that gets optimized out. (kind of like putting a break on the last
> >case of a switch statement. It doesn't do anything now, but may save
> >your bacon later if Ralph Wiggum goes playing in your code ;-))
> Fair enough :)  Although one would hope that our review process
> exists to shield us somewhat from whatever Ralph Wiggum's coding
> style throws at us :)

  Well that's not my style either, but ACK, please push :-)
Now I should fix libxml2 to support CP1252 event when iconv is not used
(may happen on Windows), but that's a small separate issue :-)


Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]