[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] introduce VIR_CLOSE to be used rather than close()



On Fri, Oct 15, 2010 at 06:06:26PM -0400, Stefan Berger wrote:
>   V3:
>    - many small nits addressed
> 
>  V2:
>     - following Eric's suggestions and picking up his code suggestions
> 
> Since bugs due to double-closed file descriptors are difficult to
> track down in a multi-threaded system, I am introducing the
> VIR_CLOSE(fd) macro to help avoid mistakes here.
> 
> There are lots of places where close() is being used. In this patch
> I am only cleaning up usage of close() in src/conf where the
> problems were.
> 
> I also dare to declare close() as being deprecated in libvirt code
> base (HACKING).
> 
> Signed-off-by: Stefan Berger <stefanb us ibm com>

  ACK, let's the cleanup begin ...

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]