[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] configure: adds an option for not using the readline library



On Mon, Oct 25, 2010 at 07:00, Justin Clift <jclift redhat com> wrote:
> On 10/25/2010 10:58 AM, Ruben Kerkhof wrote:
> <snip>
>> I think this patch is still useful for users not using homebrew.
>> I'm trying to do a (debug) build of libvirt from  a tarball outside of
>> homebrew. In this case the (keg only) readline isn't picked up.
>>
>> Even better would be an option to specify the headers/library location.
>>
>> What do you think?
>
> Ahhh, you mean like an override, which explicitly sets where libvirt
> will check for the readline headers and matching libraries?
>
> That makes sense, yeah.  :)

I got there in the end with
./configure CPPFLAGS='-I/usr/local/Cellar/libxml2/2.7.7/include
-I/usr/local/Cellar/readline/6.1/include'
LDFLAGS='-L/usr/local/Cellar/libxml2/2.7.7/lib
-L/usr/local/Cellar/readline/6.1/lib'

So I don't think the patch is really needed.

What would be good though is a AC_CHECK_LIB(readline, rl_completion_matches
This would work with readline 4.2 and higher, and fail on Leopard
since the readline shim libedit provides doesn't do completion.

> If you're interested in hacking on that yourself, you can crack open
> the configure.ac file, and look at the other bits of code in there.
>
> That's how I do most of the stuff in there, by copying other bits
> of code and then applying logic+copious testing. :)
>
> Eric Blake (and others) are pretty good at this stuff, so they often
> have suggested on how to do things better too.
>
> Your kind of thing, or are you wanting me to have a go at it? :)

As soon as I can do a proper bootstrap from git...

> (I'll happily leave it for you if you want)
>
> Regards and best wishes,
>
> Justin Clift

Thanks!

Ruben


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]