[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/2] confirm compression program availability



On Mon, 25 Oct 2010 16:20:50 +0100
"Daniel P. Berrange" <berrange redhat com> wrote:

> On Mon, Oct 25, 2010 at 09:05:29AM +0900, KAMEZAWA Hiroyuki wrote:
> > 
> > At compression, external programs are used but it is not checked whether
> > the program is available or not.
> > Check it at parsing qemu.conf and find problems in early stage.
> 
> The problem with doing the error check here is that it will
> cause the entire libvirtd to fail to startup, and just syslog
> the error. We've found admins often miss these types of problem
> in syslog and just file bugs complaining that libvirtd doesn't
> start.
> 
Hmm, yes.

> I think we should put an explicit check for existance of the
> compression program in the API code instead. That way the
> error message will get fed to the end user who will easily
> notice it.
> 

Ok, I'll try it. I wonder which is better to make the command fail or run it
in "raw" format when compression program cannot be found. Because virsh dump
cannot be stopped by Ctrl-C, starting the dump can be critical decision.

I think I should just make it fail and add "--raw" option to virsh..

Thanks,
-Kame



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]