[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] docs: install the generated html files when make install is run



On 10/26/2010 08:30 AM, Eric Blake wrote:
> On 10/24/2010 03:34 AM, Justin Clift wrote:
>> Previously, only the API docs were installed, rather than the
>> complete documentation set.  This commit ensures the complete
>> documentation set is installed.
>> ---
>>   docs/Makefile.am |   11 ++++++++++-
>>   1 files changed, 10 insertions(+), 1 deletions(-)
>>
>> @@ -169,6 +174,10 @@ rebuild: api all
>>
>>   install-data-local:
>>       $(mkinstalldirs) $(DESTDIR)$(HTML_DIR)
>> +    for f in $(css) $(dot_html); do \
>> +      $(INSTALL) -m 0644 $(srcdir)/$$f $(DESTDIR)$(HTML_DIR); done
>> +    for f in $(gif) $(png); do \
>> +      $(INSTALL) -m 0644 $(srcdir)/$$f $(DESTDIR)$(HTML_DIR); done
> 
> Any reason this is done as two for loops instead of one?

Needed more coffee, thanks for the catch. :)

Pushed, after rewriting as you suggested.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]