[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: use - not _ in memtune option names

On 10/26/2010 12:05 PM, Matthias Bolte wrote:
2010/10/26 Eric Blake<eblake redhat com>:
* tools/virsh.c (opts_memtune): All other options in virsh use -
for separating words.
  tools/virsh.c |    8 ++++----
  1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index cafd304..b616eef 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -2890,13 +2890,13 @@ static const vshCmdInfo info_memtune[] = {

  static const vshCmdOptDef opts_memtune[] = {
     {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")},
+    {"hard-limit", VSH_OT_INT, VSH_OFLAG_NONE,
      N_("Max memory in kilobytes")},

Doesn't this break calls like this in cmdMemtune:

   vshCommandOptLongLong(cmd, VIR_DOMAIN_MEMORY_HARD_LIMIT, NULL);

and this needs to be replaced by:

   vshCommandOptLongLong(cmd, "hard-limit", NULL);

Indeed. Thanks for catching that. The #defines hid from my grep; v2 coming up soon.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]