[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Fix generator for string return values



On 09/01/2010 09:32 AM, Matthias Bolte wrote:
That's a bit tricky. In case Parameter.get_type_string() is called
from Parameter.generate_return() then

   string += "%s*%s)%s" % (self.get_type_string(), self.name, end_of_line)

in line 104 adds the second *.

I attached v2 where this is simplified.

Yes, it's much easier to see in v2. ACK, if you trust my minimal python reviewing skills.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]