[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/7] round 2 of sprintf cleanups



I don't think all snprintf uses are bad - those that format a number
into an appropriately-sized maximum-possible array should be fine.
For example, there are some fixed-size buffers whose size is determined
by the kernel, where snprintf was the appropriate course of action
in nwfilter_ebiptables_driver.c.  But sprintf doesn't have quite the
coverage as snprintf, so this continuation of *printf cleanups converts
some of these.

I still have more patches to go, but this has taken me long enough
to get some more review rather than slamming a 20-patch series all
at the end.

More comments within individual patches.

Eric Blake (7):
  build: add some modules
  vbox: factor a large function
  vbox: avoid problematic uses of sprintf
  network: use virAsprintf when appropriate
  lxc: avoid large stacks with veth creation
  openvz: formatting cleanups
  openvz: use virAsprintf to avoid large stacks

 bootstrap.conf             |    2 +
 src/conf/network_conf.c    |   15 +-
 src/lxc/lxc_driver.c       |   32 +-
 src/lxc/veth.c             |   84 ++-
 src/lxc/veth.h             |    6 +-
 src/openvz/openvz_conf.c   |  142 ++--
 src/openvz/openvz_driver.c |   23 +-
 src/vbox/vbox_tmpl.c       | 2108 +++++++++++++++++++++++---------------------
 8 files changed, 1269 insertions(+), 1143 deletions(-)

-- 
1.7.2.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]