[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Fix generator for string return values



2010/9/1 Eric Blake <eblake redhat com>:
> On 09/01/2010 09:32 AM, Matthias Bolte wrote:
>>
>> That's a bit tricky. In case Parameter.get_type_string() is called
>> from Parameter.generate_return() then
>>
>>   string += "%s*%s)%s" % (self.get_type_string(), self.name, end_of_line)
>>
>> in line 104 adds the second *.
>>
>> I attached v2 where this is simplified.
>
> Yes, it's much easier to see in v2.  ACK, if you trust my minimal python
> reviewing skills.
>

Well, your first review already improved the patch :)

Thanks, pushed v2.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]