[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Rework datastore path parsing and handling



2010/9/3 Eric Blake <eblake redhat com>:
> On 09/02/2010 04:00 PM, Matthias Bolte wrote:
>>>
>>> Are you missing a strdup() here?  I'm worried that the
>>> VIR_FREE(data.datastorePathWithoutFileName) in esxDomainDumpXML will now
>>> try
>>> to free static storage.
>>
>> This is in esxDomainXMLFromNative, data.datastorePathWithoutFileName
>> doesn't get freed here, so not strdup'ing is fine here.
>>
>> In esxDomainDumpXML data.datastorePathWithoutFileName is allocated via
>> virAsprintf and therefore it need to be freed in esxDomainDumpXML.
>>
>> So nothing to change here.
>
> Okay; your explanations make sense.
>
> ACK.
>

Thanks, pushed.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]