[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Use SED variable for `sed` binary in src/Makefile



On Wed, Sep 08, 2010 at 11:41:52PM -0700, Mitchell Hashimoto wrote:
> Hm, the patch attached as binary data. Here is the attached patch as text.
> Apologies about that:
> 
> ---
>  src/Makefile.am |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index b321657..118c329 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -1029,14 +1029,14 @@ libvirt.syms: libvirt_public.syms $(USED_SYM_FILES)
>  libvirt.def: libvirt.syms
>         $(AM_V_GEN)rm -f -- $ -tmp $@ ; \
>         printf 'EXPORTS\n' > $ -tmp && \
> -       sed -e '/^$$/d; /#/d; /:/d; /\}/d; /\*/d; /LIBVIRT_/d; s/[
> \t]*\(.*\)\;/    \1/g' $^ >> $ -tmp && \
> +       $(SED) -e '/^$$/d; /#/d; /:/d; /\}/d; /\*/d; /LIBVIRT_/d; s/[
> \t]*\(.*\)\;/    \1/g' $^ >> $ -tmp && \
>         chmod a-w $ -tmp && \
>         mv $ -tmp libvirt.def
> 
>  libvirt_qemu.def: $(srcdir)/libvirt_qemu.syms
>         $(AM_V_GEN)rm -f -- $ -tmp $@ ; \
>         printf 'EXPORTS\n' > $ -tmp && \
> -       sed -e '/^$$/d; /#/d; /:/d; /\}/d; /\*/d; /LIBVIRT_/d; s/[
> \t]*\(.*\)\;/    \1/g' $^ >> $ -tmp && \
> +       $(SED) -e '/^$$/d; /#/d; /:/d; /\}/d; /\*/d; /LIBVIRT_/d; s/[
> \t]*\(.*\)\;/    \1/g' $^ >> $ -tmp && \
>         chmod a-w $ -tmp && \
>         mv $ -tmp libvirt_qemu.def

I think you also need to add AC_PROG_SED to configure.ac.  At the
moment it is being defined, but only incidentally because of some
other macro.

There are also uses of sed, at least one in configure.ac itself ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]