[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/3] test cases for spoofing prevention



On Fri, Sep 10, 2010 at 04:02:16PM +0200, Gerhard Stenzel wrote:
> On Fri, 2010-09-10 at 10:45 +0100, Daniel P. Berrange wrote:
> > Thanks, this one worked fine for me. I've committed your patches to
> > the GIT repository, and added a couple of follow on changes. I made
> > it use virtio instead of scsi for the disk, since RHEL6 doesn't ship
> > with SCSI enabled. I also use mkisofs to put the kickstart file into
> > a tiny ISO image and then boot with ks=cdrom:/ks.cfg so we can avoid
> > needing a web service in the host to provision it. I also changed the
> > filter name from 'no-spoofing' to 'clean-traffic' since libvirt does
> > not have any 'no-spoofing' filter by default & IIUC 'clean-traffic'
> > should be suitable for your tests.
> 
> Sounds good and I will give it a try ...
> 
> In the meantime, I think your spec(.PL) file misses something like the
> following:
> 
> diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
> index aaca325..ecc979c 100644
> --- a/perl-Sys-Virt-TCK.spec.PL
> +++ b/perl-Sys-Virt-TCK.spec.PL
> @@ -118,6 +118,7 @@ rm -rf $RPM_BUILD_ROOT
>  %{perlvendorlib}/Sys/Virt/TCK.pm
>  %{perlvendorlib}/Sys/Virt/TCK/
>  %dir %{_localstatedir}/cache/libvirt-tck
> +/etc/libvirt-tck/ks.cfg

Yes, good point. I've added this.


Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]