[libvirt] [PATCH 2/2] tests: silence qemuargv2xmltest noise

Daniel P. Berrange berrange at redhat.com
Fri Sep 10 16:42:18 UTC 2010


On Fri, Sep 10, 2010 at 10:29:37AM -0600, Eric Blake wrote:
> * tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
> Use flag to mark which tests expect noisy stderr.
> (testCompareXMLToArgvFiles): Add parameter to test whether stderr
> was appropriately silent.
> ---
> 
> This doesn't actually validate the contents of the warning put to
> stderr, but it's better than nothing as it tightens the test and
> reduces the noise.

What warnings are you seeing on stderr ?? The test suite really
shouldn't print anything on stderr unless there's a real failure
occurring, so I'm not sure that we need to/should hide stderr

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




More information about the libvir-list mailing list