[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] tests: silence qemuargv2xmltest noise



On 09/10/2010 10:42 AM, Daniel P. Berrange wrote:
On Fri, Sep 10, 2010 at 10:29:37AM -0600, Eric Blake wrote:
* tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
Use flag to mark which tests expect noisy stderr.
(testCompareXMLToArgvFiles): Add parameter to test whether stderr
was appropriately silent.
---

This doesn't actually validate the contents of the warning put to
stderr, but it's better than nothing as it tightens the test and
reduces the noise.

What warnings are you seeing on stderr ?? The test suite really
shouldn't print anything on stderr unless there's a real failure
occurring, so I'm not sure that we need to/should hide stderr

These are the warnings related to using the qemu monitoring commands added in 0.8.3:

TEST: qemuargv2xmltest
      ........................................ 40
................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace 20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
.                        57  OK
PASS: qemuargv2xmltest

It's not a real failure (which is why the test was completing successfully), so much as an intentional warning to the user that use of the qemu namespace has the potential for undefined effects. After this patch series, the test now explicitly checks for the presence or absence of the warning, such that the test output becomes:

TEST: qemuargv2xmltest
      ........................................ 40
      .................                        57  OK
PASS: qemuargv2xmltest

I guess I should have put this in the commit message to 2/2.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]