[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: Use virBuffer for generating XML



> > @@ -7903,52 +7904,40 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd)
> >       }
> >
> >       /* Make XML of interface */
> > -    tmp = vshMalloc(ctl, 1);
> > -    buf = vshMalloc(ctl, strlen(type) + 25);
> > -    sprintf(buf, "<interface type='%s'>\n" , type);
> > +    virBufferVSprintf(&buf, "<interface type='%s'>\n" , type);
> 
> Weird spacing before the second comma

Oops, I didn't notice this weirdness in the original code and let it slip into
the new one. I fixed that and pushed, thanks.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]