[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nwfilter: fix an bug appearing on big endian machines



On Fri, Sep 17, 2010 at 02:21:56PM -0400, Stefan Berger wrote:
>  Either one of the following patches fixes a bug appearing on big 
> endian machines where the returned XML is not the one that is expected 
> (see test/nwfilterxml2xmltest). The problem is due to for example the 
> casting of a pointers to unsigned integers to void * and then back to 16 
> bit integers.
> 
> I have prepared 2 different solutions for the problem. I think the one 
> with the union is the better one, which I am posting before the shorted 
> solution. Both solutions make the nwfilterxml2xmltest pass on a ppc64 
> machine.

I'd pick the one with the union too, so ACK to that one.

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]