[libvirt] [PATCH 03/12] Adds xml entries for memory tunables
Daniel P. Berrange
berrange at redhat.com
Tue Sep 21 17:14:51 UTC 2010
On Mon, Sep 20, 2010 at 02:15:37PM +0530, Nikunj A. Dadhania wrote:
> The patch adds xml entries to the domain.rng file.
>
> Signed-off-by: Nikunj A. Dadhania <nikunj at linux.vnet.ibm.com>
> ---
> docs/schemas/domain.rng | 31 +++++++++++++++++++++++++++++++
> 1 files changed, 31 insertions(+), 0 deletions(-)
>
> diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
> index ccb8cf3..6d123ab 100644
> --- a/docs/schemas/domain.rng
> +++ b/docs/schemas/domain.rng
> @@ -299,6 +299,37 @@
> </optional>
> </element>
> </optional>
> +
> + <!-- All the memory/swap related tunables would go in the memtune -->
> + <optional>
> + <element name="memtune">
> + <!-- Maximum memory the VM can use -->
> + <optional>
> + <element name="hard_limit">
> + <ref name="memoryKB"/>
> + </element>
> + </optional>
> + <!-- Minimum memory ascertained for the VM during contention -->
> + <optional>
> + <element name="soft_limit">
> + <ref name="memoryKB"/>
> + </element>
> + </optional>
> + <!-- Minimum amount of memory required to start the VM -->
> + <optional>
> + <element name="min_gaurantee">
Small typo there, s/gaur/guar/
> + <ref name="memoryKB"/>
> + </element>
> + </optional>
> + <!-- Maximum swap area the VM can use -->
> + <optional>
> + <element name="swap_hard_limit">
> + <ref name="memoryKB"/>
> + </element>
> + </optional>
> + </element>
> + </optional>
> +
> <optional>
Also the indentation looks a bit wacky. Tabs in the file perhaps ?
> <element name="vcpu">
> <optional>
The schema additions look fine to me though.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list