[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Enable support for nested SVM

On 09/22/2010 10:47 AM, Daniel P. Berrange wrote:

Marking patches as v2 makes it easier for reviewers to note that this is fixing comments from an earlier review :)

This enables support for nested SVM using the regular CPU
model/features block. If the CPU model or features include
'svm' or 'vmx', then the '-enable-nesting' flag will be
added to the QEMU command line. Several of the models
already include svm support, but QEMU was just masking out
the svm bit silently. So this will enable SVM on such

ACK to this patch, but...

+++ b/src/qemu/qemu_conf.h
@@ -93,6 +93,7 @@ enum qemud_cmd_flags {
      QEMUD_CMD_FLAG_NODEFCONFIG   = (1LL<<  37), /* -nodefconfig */
      QEMUD_CMD_FLAG_BOOT_MENU     = (1LL<<  38), /* -boot menu=on support */
      QEMUD_CMD_FLAG_ENABLE_KQEMU  = (1LL<<  39), /* -enable-kqemu flag */
+    QEMUD_CMD_FLAG_NESTING       = (1LL<<  40), /* -enable-nesting (SVM/VMX) */

...as a followup, should we add to tests/qemuhelpdata an example of qemu output that supports -enable-nesting, to be sure the parser works correctly?

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]