[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add automatic generation of a todo item page



On 09/21/2010 09:42 AM, Daniel P. Berrange wrote:
This adds a script to generate the todo item page from
bugzilla. This requires a valid username+password for
bugzilla, so it is intended that this only be run on
the libvirt.org website via cron. Normal usage will just
generate an empty stub page.

Cool!


* docs/todo.pl: Script to extract todo items from bugzilla
* docs/todo.cfg-example: Example config file
* docs/sitemap.html.in: Add todo page
* docs/Makefile.am: Generation rules for todo items
---
  docs/.gitignore       |    1 +
  docs/Makefile.am      |   20 +++++++-
  docs/sitemap.html.in  |    6 +++
  docs/todo.cfg-example |   26 +++++++++++
  docs/todo.pl          |  120 +++++++++++++++++++++++++++++++++++++++++++++++++
  5 files changed, 171 insertions(+), 2 deletions(-)
  create mode 100644 docs/todo.cfg-example
  create mode 100644 docs/todo.pl

chmod +x docs/todo.pl

+todo.html.in: todo.pl
+	if [ -f  todo.cfg ]; then \
+		echo "Generating $@"; \
+		$(PERL) $(srcdir)/$<  >  $@ \
+		|| { rm $@&&  exit 1; }; \
+	else \
+		echo "Stubbing $@"; \
+		echo "<html><body><h1>Todo list</h1></body></html>">>  $@ ; \

Why >> instead of > ?

+	fi
+
+todo:
+	rm -f todo.html.in
+	$(MAKE) todo.html

Should todo be marked .PHONY?

+
+print "<p>\n";
+print "    This page is automatatically generated from<a href=\"$server/$todoid\">",&escape($todosummary), "</a>\n";

s/automatatically/automatically/

ACK with those nits fixed.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]