[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/5] Extend XML parser and generator to support comment attribute

On 09/27/2010 12:40 PM, Stefan Berger wrote:
  - introducing a field 'maxstrlen' to control the length of accepted string
  - removed function validating comment string assuming the XML parser
    already sinity checked the string

s/sinity/sanity/, if you leave this in your commit message

The patch below extends the XML parser and generator so that every protocol
now can have a comment node. Comments are limited to 256 characters and are
tested to only contain printable characters or spaces.

Literal spaces, or generic blanks (space and tab for sure, but what about newline, not to mention vertical tab, form feed, ...), all of which are technically printable according to c_isprint()?

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]