[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 5/5] Add a test case for testing the comment attribute



On 09/27/2010 12:40 PM, Stefan Berger wrote:
+  <rule action='accept' direction='in'>
+     <udp-ipv6 srcmacaddr='1:2:3:4:5:6'
+               srcipaddr='a:b:c::' srcipmask='128'
+               dscp='0x40'
+               srcportstart='0x20' srcportend='0x21'
+               dstportstart='0x100' dstportend='0x1111'
+               comment='`ls`;${COLUMNS};$(ls);"test";&amp;&apos;3   spaces&apos;'/>

Should we also be testing \, <, or *? Also, your tests for " and ' are balanced; do unbalanced " or ' expose any problems?

But this is indeed a useful patch, given the churn I'm putting you through on the rest of the series :)

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]