[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] python: drop unneccesary conn assignment

On 09/27/2010 02:58 AM, Dan Kenigsberg wrote:
Since 554d82a200289938d5639a782a9f12e3e2e968f0, conn is unused. Let's
drop it - but keep the signature of the constructor for backward
  python/libvirt-override.py |    9 ---------
  1 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/python/libvirt-override.py b/python/libvirt-override.py
index de1af2d..d544a0e 100644
--- a/python/libvirt-override.py
+++ b/python/libvirt-override.py
@@ -18,15 +18,6 @@ import types
  class libvirtError(Exception):
      def __init__(self, defmsg, conn=None, dom=None, net=None, pool=None, vol=None):

-        if dom is not None:
-            conn = dom._conn
-        elif net is not None:
-            conn = net._conn
-        elif pool is not None:
-            conn = pool._conn
-        elif vol is not None:
-            conn = vol._conn

ACK, and pushed after fixing s/unneccesary/unnecessary/ in the title.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]