[libvirt] [PATCH] free tmp after unlinking it
Wen Congyang
wency at cn.fujitsu.com
Fri Apr 1 03:17:57 UTC 2011
At 03/31/2011 06:49 PM, Daniel P. Berrange Write:
> On Thu, Mar 31, 2011 at 04:23:33PM +0800, Wen Congyang wrote:
>> ---
>> src/qemu/qemu_driver.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>> index dd12dc8..5aa715e 100644
>> --- a/src/qemu/qemu_driver.c
>> +++ b/src/qemu/qemu_driver.c
>> @@ -5065,9 +5065,9 @@ endjob:
>> vm = NULL;
>>
>> cleanup:
>> - VIR_FREE(tmp);
>> VIR_FORCE_CLOSE(fd);
>> unlink (tmp);
>> + VIR_FREE(tmp);
>> if (vm)
>> virDomainObjUnlock(vm);
>> return ret;
>
> ACK, but can you write a bit of a longer commit message
> saying what area of code / method this is fixing, because
> the diff context is not showing the method name.
I added a commit message and pushed it.
Thanks.
>
> Daniel
More information about the libvir-list
mailing list