[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] free tmp after unlinking it



At 03/31/2011 05:11 PM, Daniel Veillard Write:
> On Thu, Mar 31, 2011 at 04:23:33PM +0800, Wen Congyang wrote:
>> ---
>>  src/qemu/qemu_driver.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>> index dd12dc8..5aa715e 100644
>> --- a/src/qemu/qemu_driver.c
>> +++ b/src/qemu/qemu_driver.c
>> @@ -5065,9 +5065,9 @@ endjob:
>>          vm = NULL;
>>  
>>  cleanup:
>> -    VIR_FREE(tmp);
>>      VIR_FORCE_CLOSE(fd);
>>      unlink (tmp);
>> +    VIR_FREE(tmp);
>>      if (vm)
>>          virDomainObjUnlock(vm);
>>      return ret;
> 
>  Houla ! ACK !!!
> BTW, how did you find this, code review, valgrind or something else ?

I found this when I was checking all the place that calls qemuDomainObjExitMonitor()
/qemuDomainObjExitMonitorWithDriver().

> 
>   thanks,
> 
> Daniel
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]