[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-php] Remove strip from installation



On 03/31/2011 11:25 PM, Lyre wrote:
> Make it able to generate debuginfo package.
>  
>  install-exec-local:
> -	$(INSTALL) -m 644 -D --strip $(PACKAGE).so $(DESTDIR)$(PHPEDIR)/$(PACKAGE).so
> +	$(INSTALL) -m 644 -D $(PACKAGE).so $(DESTDIR)$(PHPEDIR)/$(PACKAGE).so
>  	$(INSTALL) -m 755 -d $(DESTDIR)$(PHPCDIR)
>  	$(ECHO) "extension=$(PACKAGE).so" > $(DESTDIR)$(PHPCDIR)/libvirt-php.ini

Good change.  GNU Coding Standards recommend, and Automake provides,
'make install' with debug vs. 'make install-strip' with stripped
binaries; and 'make install-strip' works by reinvoking 'make install'
with $(INSTALL) redefined to also do stripping.  So it is still possible
to install things stripped by specifically asking for it, but stripping
should never be the default.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]