[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] do not lock vm while allocating memory



On 03/30/2011 01:46 AM, Wen Congyang wrote:
> There is no need to lock vm while allocating memory. If allocating
> memory failed, we forgot to unlock vm.
> 
> ---
>  src/qemu/qemu_process.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index e31e1b4..e74e0f1 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -525,8 +525,6 @@ qemuProcessHandleGraphics(qemuMonitorPtr mon ATTRIBUTE_UNUSED,
>      virDomainEventGraphicsSubjectPtr subject = NULL;
>      int i;
>  
> -    virDomainObjLock(vm);
> -
>      if (VIR_ALLOC(localAddr) < 0)
>          goto no_memory;
>      localAddr->family = localFamily;
> @@ -560,6 +558,7 @@ qemuProcessHandleGraphics(qemuMonitorPtr mon ATTRIBUTE_UNUSED,
>          subject->nidentity++;
>      }
>  
> +    virDomainObjLock(vm);

ACK.  It only affects the OOM path, but is worth including in 0.9.0.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]