[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Rewrite LOOKUP_PTYS macro into a function



On 04/04/2011 07:46 AM, Jiri Denemark wrote:
> The macro is huge and gives us nothing but headache when maintaining it.
> ---
> The reason for this patch is not that I'm going to modify anything in
> the code. It's that I was working in the area and noticed this huge
> macro.
> 
>  src/qemu/qemu_process.c |  102 ++++++++++++++++++++++++++++-------------------
>  1 files changed, 61 insertions(+), 41 deletions(-)

The diffstat hides the fact that this really is a code cleanup.

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]