[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] remove devices from driver->activePciHostdevs when qemuPrepareHostdevPCIDevices() failed



On 03/28/2011 01:01 AM, Wen Congyang wrote:
> We should not mark pci devices as active when qemuPrepareHostdevPCIDevices()
> failed.
> 
> ---
>  src/qemu/qemu_hostdev.c |   21 ++++++++++++++++++---
>  1 files changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c
> index f4b2108..30db0e2 100644
> --- a/src/qemu/qemu_hostdev.c
> +++ b/src/qemu/qemu_hostdev.c
> @@ -112,7 +112,7 @@ int qemuPrepareHostdevPCIDevices(struct qemud_driver *driver,
>      if (!(pcidevs = qemuGetPciHostDeviceList(hostdevs, nhostdevs)))
>          return -1;
>  
> -    /* We have to use 3 loops here. *All* devices must
> +    /* We have to use 4 loops here. *All* devices must

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]