[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] reattach pci devices when qemuPrepareHostdevPCIDevices() failed



On 03/28/2011 01:01 AM, Wen Congyang wrote:
> Reattach all pci devices that we detached when qemuPrepareHostdevPCIDevices()
> failed.
> 
> ---
>  src/qemu/qemu_hostdev.c |   12 +++++++++---
>  1 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c
> index 30db0e2..7f5ad51 100644
> --- a/src/qemu/qemu_hostdev.c
> +++ b/src/qemu/qemu_hostdev.c
> @@ -127,11 +127,11 @@ int qemuPrepareHostdevPCIDevices(struct qemud_driver *driver,
>      for (i = 0; i < pciDeviceListCount(pcidevs); i++) {
>          pciDevice *dev = pciDeviceListGet(pcidevs, i);
>          if (!pciDeviceIsAssignable(dev, !driver->relaxedACS))
> -            goto cleanup;
> +            goto reattachdevs;
>  
>          if (pciDeviceGetManaged(dev) &&
>              pciDettachDevice(dev, driver->activePciHostdevs) < 0)
> -            goto cleanup;
> +            goto reattachdevs;

Makes sense; ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]